Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update config.json to support type-specific example highlighting #458

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

Zamoca42
Copy link
Contributor

@Zamoca42 Zamoca42 commented Nov 3, 2024

Description

Fixes #397
Follow up of the PR #444
The feature for type-based highlighting has been implemented in the example, but themes have not been applied. You need to update config.json to apply type-based themes in the example.

The newly applied theme in config.json is a prototype.

Before Theme Update

before

After Theme Update

after

Checklist

Please review this checklist before submitting a pull request.

  • Code compiles correctly
  • Created tests, if possible
  • All tests passing (npm run test:all)
  • Extended the README / documentation, if necessary

Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution.

Copy link
Member

@renie renie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for your contribution!

@renie renie merged commit aa81ea6 into tldr-pages:main Nov 5, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight number, string and boolean placeholders differently
3 participants